Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class method completion #1741

Merged
merged 2 commits into from
Apr 17, 2021
Merged

Fix class method completion #1741

merged 2 commits into from
Apr 17, 2021

Conversation

July541
Copy link
Collaborator

@July541 July541 commented Apr 17, 2021

Fix #1738.

From docs, the signature of a class method should be ClassOpSig.

pepeiborra
pepeiborra approved these changes Apr 17, 2021
View reviewed changes
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, and thanks for the test!

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Apr 17, 2021
@mergify mergify bot merged commit eb049c6 into haskell:master Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepeiborra pepeiborra pepeiborra approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Completions for methods of the current class in instance declarations
2 participants
@July541 @pepeiborra