Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for GHC 8.10.5 on macOS #1931

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Workaround for GHC 8.10.5 on macOS #1931

merged 4 commits into from
Jun 16, 2021

Conversation

konn
Copy link
Collaborator

@konn konn commented Jun 16, 2021

As pointed out by @mouse07410 in #1913, we can build HLS with GHC 8.10.5 on macOS just by removing CommandLineTools from the environment.
This PR tries to adopt this workaround in a rather ad-hoc manner.

@konn
Copy link
Collaborator Author

konn commented Jun 16, 2021

I want to test build action for GHC 8.10.5 + macOS - is there any way to invoke the build workflow manually?

@jneira
Copy link
Member

jneira commented Jun 16, 2021

I want to test build action for GHC 8.10.5 + macOS - is there any way to invoke the build workflow manually?

It is triggered on releases so i usually test them in my repo, creating a fake release there and delete it after the test.
(We could change the trigger in the script and restore it after the test but i would recommend test it in your repo, you could link to your succesful build for completeness)

@konn
Copy link
Collaborator Author

konn commented Jun 16, 2021

@konn
Copy link
Collaborator Author

konn commented Jun 16, 2021

Hurray! It at least builds the network with GHC 8.10.5 on macOS 🎉

スクリーンショット 2021-06-16 18 02 31

@Ailrun
Copy link
Member

Ailrun commented Jun 16, 2021

Awesome! Now we can have GHC 8.10.5 on macOS for future versions too :)

@konn
Copy link
Collaborator Author

konn commented Jun 16, 2021

OK, it finally generated HLS binary for GHC 8.10.5 on macOS 🎉

スクリーンショット 2021-06-16 18 29 47

@konn
Copy link
Collaborator Author

konn commented Jun 16, 2021

I will re-upload the HLS exes generated by GHA for macOS to haskell/haskell-language-server after the test CI successfully passes.

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, many thanks, macOS users will be grateful

@konn
Copy link
Collaborator Author

konn commented Jun 16, 2021

The hack incoporated in this pull request is essentially due to @mouse07410.
Credit goes to them, great discovery!

@konn
Copy link
Collaborator Author

konn commented Jun 16, 2021

Oops, tests got cancelled by ghc 9 failure -- is this intended behaviour?

@konn
Copy link
Collaborator Author

konn commented Jun 16, 2021

Ah, I used the wrong commit to build 1.2.0 on my fork repository. This Pull Request itself is correct, but I will re-run the dummy release on my fork to generate macOS binaries with the correct commit.

@konn
Copy link
Collaborator Author

konn commented Jun 16, 2021

I've just re-uploaded gzip and tarballs, as it seems all the tests pass now.

@jneira jneira merged commit 5db0108 into master Jun 16, 2021
@jneira
Copy link
Member

jneira commented Jun 16, 2021

good to merge then, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants