-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for GHC 8.10.5 on macOS #1931
Conversation
I want to test build action for GHC 8.10.5 + macOS - is there any way to invoke the build workflow manually? |
It is triggered on releases so i usually test them in my repo, creating a fake release there and delete it after the test. |
Awesome! Now we can have GHC 8.10.5 on macOS for future versions too :) |
I will re-upload the HLS exes generated by GHA for macOS to haskell/haskell-language-server after the test CI successfully passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, many thanks, macOS users will be grateful
The hack incoporated in this pull request is essentially due to @mouse07410. |
Oops, tests got cancelled by ghc 9 failure -- is this intended behaviour? |
Ah, I used the wrong commit to build 1.2.0 on my fork repository. This Pull Request itself is correct, but I will re-run the dummy release on my fork to generate macOS binaries with the correct commit. |
I've just re-uploaded gzip and tarballs, as it seems all the tests pass now. |
good to merge then, thanks again |
As pointed out by @mouse07410 in #1913, we can build HLS with GHC 8.10.5 on macOS just by removing CommandLineTools from the environment.
This PR tries to adopt this workaround in a rather ad-hoc manner.