Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ghcup compile option #2230

Merged
merged 10 commits into from
Oct 4, 2021
Merged

Add ghcup compile option #2230

merged 10 commits into from
Oct 4, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Sep 22, 2021

docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
jneira and others added 3 commits September 22, 2021 12:27
Co-authored-by: Julian Ospald <hasufell@posteo.de>
Co-authored-by: Julian Ospald <hasufell@posteo.de>
docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
@jneira jneira changed the title Add ghcup freebsd and compile options Add ghcup compile option Sep 23, 2021
@michaelpj
Copy link
Collaborator

Aha, I found a platform support table for gchup! Maybe we should link to that? Or I guess we could just let users find it themselves if they wonder.

https://gitlab.haskell.org/haskell/ghcup-hs#supported-platforms

@jneira
Copy link
Member Author

jneira commented Sep 23, 2021

Aha, I found a platform support table for gchup! Maybe we should link to that? Or I guess we could just let users find it themselves if they wonder.

https://gitlab.haskell.org/haskell/ghcup-hs#supported-platforms

looks good, many thanks! i think it worths to link it here

@jneira
Copy link
Member Author

jneira commented Sep 23, 2021

@michaelpj do you think this could be merged?

@jneira jneira added the merge me Label to trigger pull request merge label Sep 24, 2021
@michaelpj
Copy link
Collaborator

LGTM!

@hasufell
Copy link
Member

Sidenote, #2216 is relevant to this

@jneira
Copy link
Member Author

jneira commented Sep 27, 2021

I think i ve tried 5 or so reruns and the test for windows still fails over and over (last time tactics for win and ghc-810.7)

@jneira
Copy link
Member Author

jneira commented Sep 30, 2021

/rerun-workflow Testing

@pepeiborra
Copy link
Collaborator

I think i ve tried 5 or so reruns and the test for windows still fails over and over (last time tactics for win and ghc-810.7)

The tactics suite is flaky because it runs tests in parallel and the tactics plugin has an internal timeout. We should probably run all the test suites sequentially since the CI runners only have 1 core anyway.

@jneira
Copy link
Member Author

jneira commented Oct 1, 2021

hmm, but tests are already being run with j1, what do you mean with run sequentally? pass j1 to cabal itself?

EDIT: last fail was in hls-eval-plugin

@mergify mergify bot merged commit 21c42d5 into master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update freebsd installation instructions
4 participants