Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix defaultIdeOptions to use the initial config settings #2302

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Fix defaultIdeOptions to use the initial config settings #2302

merged 1 commit into from
Oct 25, 2021

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Oct 25, 2021 •
edited by gitpod-io bot
Loading

defaultIdeOptions should use the initial config values for checkProject and checkParents, which can be set via the LSP initialisation request

@pepeiborra
fix defaultIdeOptions
48237d6 
It should use the default config settings for checkProject and checkParents
jneira
jneira approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pepeiborra pepeiborra mentioned this pull request Oct 25, 2021
Closed
@pepeiborra pepeiborra merged commit 44016a7 into master Oct 25, 2021
@pepeiborra pepeiborra deleted the fix-defaultIdeOptions branch October 25, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pepeiborra @jneira