Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on FreeBSD12 only #2420

Merged
merged 9 commits into from
Dec 6, 2021
Merged

Build on FreeBSD12 only #2420

merged 9 commits into from
Dec 6, 2021

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Nov 30, 2021

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks for fixing the gitlab builds

[skip circleci]

@jneira jneira added the merge me Label to trigger pull request merge label Nov 30, 2021
@hasufell hasufell marked this pull request as draft November 30, 2021 21:00
@hasufell hasufell marked this pull request as ready for review November 30, 2021 21:51
@hasufell hasufell marked this pull request as draft November 30, 2021 22:06
@hasufell hasufell force-pushed the gitlab-ci-freebsd branch 3 times, most recently from 94eb3e2 to 0e260e0 Compare December 1, 2021 00:18
@jneira jneira mentioned this pull request Dec 1, 2021
27 tasks
@hasufell
Copy link
Member Author

hasufell commented Dec 1, 2021

Windows 8.8.4 fails: https://gitlab.haskell.org/maerwald/haskell-language-server/-/jobs/872984

ghc.exe: addLibrarySearchPath: C:\GitLabRunner\builds\0\872984\toolchain\ghcup\msys64\ming[2 of 2] Compiling Paths_haskell_language_server ( C:\GitLabRunner\builds\0\872984\dist-newstyle\build\x86_64-windows\ghc-8.8.4\haskell-language-server-1.5.1.0\x\haskell-language-server-wrapper\opt\build\haskell-language-server-wrapper\autogen\Paths_haskell_language_server.hs, C:\GitLabRunner\builds\0\872984\dist-newstyle\build\x86_64-windows\ghc-8.8.4\haskell-language-server-1.5.1.0\x\haskell-language-server-wrapper\opt\build\haskell-language-server-wrapper\haskell-language-server-wrapper-tmp\Paths_haskell_language_server.o )
Assembler messages:
Fatal error: can't create C:\\GitLabRunner\\builds\\0\\872984\\dist-newstyle\\build\\x86_64-windows\\ghc-8.8.4\\haskell-language-server-1.5.1.0\\x\\haskell-language-server-wrapper\\opt\\build\\haskell-language-server-wrapper\\haskell-language-server-wrapper-tmp\\Paths_haskell_language_server.o: No such file or directory
`gcc.exe' failed in phase `Assembler'. (Exit code: 1)

@hasufell hasufell marked this pull request as ready for review December 1, 2021 19:56
@hasufell
Copy link
Member Author

hasufell commented Dec 1, 2021

https://gitlab.haskell.org/maerwald/haskell-language-server/-/pipelines/44701 looks good and should be finished soon

@jneira
Copy link
Member

jneira commented Dec 1, 2021

Windows 8.8.4 fails: https://gitlab.haskell.org/maerwald/haskell-language-server/-/jobs/872984

ghc.exe: addLibrarySearchPath: C:\GitLabRunner\builds\0\872984\toolchain\ghcup\msys64\ming[2 of 2] Compiling Paths_haskell_language_server ( C:\GitLabRunner\builds\0\872984\dist-newstyle\build\x86_64-windows\ghc-8.8.4\haskell-language-server-1.5.1.0\x\haskell-language-server-wrapper\opt\build\haskell-language-server-wrapper\autogen\Paths_haskell_language_server.hs, C:\GitLabRunner\builds\0\872984\dist-newstyle\build\x86_64-windows\ghc-8.8.4\haskell-language-server-1.5.1.0\x\haskell-language-server-wrapper\opt\build\haskell-language-server-wrapper\haskell-language-server-wrapper-tmp\Paths_haskell_language_server.o )
Assembler messages:
Fatal error: can't create C:\\GitLabRunner\\builds\\0\\872984\\dist-newstyle\\build\\x86_64-windows\\ghc-8.8.4\\haskell-language-server-1.5.1.0\\x\\haskell-language-server-wrapper\\opt\\build\\haskell-language-server-wrapper\\haskell-language-server-wrapper-tmp\\Paths_haskell_language_server.o: No such file or directory
`gcc.exe' failed in phase `Assembler'. (Exit code: 1)

that is due to the long path generated, we had to workaround in gh with this trick:

# Need this to work around filepath length limits in Windows
- name: Shorten binary names
run: |
sed -i.bak -e 's/haskell-language-server/hls/g' \
-e 's/haskell_language_server/hls/g' \
haskell-language-server.cabal cabal.project
sed -i.bak -e 's/Paths_haskell_language_server/Paths_hls/g' \
src/**/*.hs exe/*.hs

@hasufell
Copy link
Member Author

hasufell commented Dec 1, 2021

that is due to the long path generated, we had to workaround in gh with this trick:

I already fixed that

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks for fix the builds and make easy the distribution of artifacts

@hasufell hasufell marked this pull request as draft December 1, 2021 22:33
@hasufell
Copy link
Member Author

hasufell commented Dec 1, 2021

postponing merge because I added commits that try to tar up the executables better... will have to see how it goes: https://gitlab.haskell.org/maerwald/haskell-language-server/-/pipelines/44715

@hasufell hasufell marked this pull request as ready for review December 2, 2021 13:42
@hasufell
Copy link
Member Author

hasufell commented Dec 2, 2021

should be done

.gitlab-ci.yml Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
@hasufell
Copy link
Member Author

hasufell commented Dec 5, 2021

???

@jneira
Copy link
Member

jneira commented Dec 5, 2021

the branch has to be in sync with master to be merged

@mergify mergify bot merged commit e74cf55 into haskell:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants