Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if TH and Mac and static binary #2470

Merged
merged 7 commits into from
Dec 13, 2021
Merged

Warn if TH and Mac and static binary #2470

merged 7 commits into from
Dec 13, 2021

Conversation

pepeiborra
Copy link
Collaborator

@pepeiborra pepeiborra commented Dec 11, 2021

Closes #2391

Screen.Recording.2021-12-11.at.20.47.03.mov

@jneira
Copy link
Member

jneira commented Dec 11, 2021

This is really a good idea and the suggestion is helpful. However is not the first statement a little bit strong? I mean, i thought template haskell was working at least for some cases. The warning could be surprising for those who th works.

@pepeiborra
Copy link
Collaborator Author

pepeiborra commented Dec 12, 2021

This is really a good idea and the suggestion is helpful. However is not the first statement a little bit strong? I mean, i thought template haskell was working at least for some cases. The warning could be surprising for those who th works.

For me Haskell should never segfault, it's a horrible user experience. Therefore, TH in MacOs with a statically linked binary doesn't work.

Secondly, the statement is strictly true: we don't support TH in Mac OS with a statically linked binary: no one is working on fixing the problems, which involve bugs in the Mach linker in GHC.

Do you have any concrete suggestions?

@jneira
Copy link
Member

jneira commented Dec 12, 2021

I just saw it is exclusive for macos and it is not emitted for Linux. I would add a weak version for Linux as th cause problems in that os but we can wait to see what is the effect of alpine binaries

@pepeiborra pepeiborra added the merge me Label to trigger pull request merge label Dec 12, 2021
@jneira
Copy link
Member

jneira commented Dec 12, 2021

It seems hie-bios should be updated to 0.8.0 in stack.yaml's to get hostIsDynamic

@mergify mergify bot merged commit 807cb8f into master Dec 13, 2021
jneira added a commit to jneira/haskell-language-server that referenced this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display a warning when using Template Haskell and static binaries
2 participants