Fix redundant import actions for names starting with _ #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
reviewed
Dec 13, 2021
pepeiborra
approved these changes
Dec 13, 2021
Ailrun
force-pushed
the
fix-redundant-import
branch
from
9156b6c
to
ebd0912
Compare
drsooch
added a commit
to drsooch/haskell-language-server
that referenced
this pull request
Apr 30, 2022
Instead of using a low-level `is_ident` that only works on ascii characters. Instead match directly on the '_' character. The original functionality has been restored (using `isAlpha` instead). This commit removes the now unneccessary `is_ident` compat layer
drsooch
added a commit
to drsooch/haskell-language-server
that referenced
this pull request
Apr 30, 2022
Instead of using a low-level `is_ident` that only works on ascii characters. Instead match directly on the '_' character. The original functionality has been restored (using `isAlpha` instead). This commit removes the now unneccessary `is_ident` compat layer
mergify bot
added a commit
that referenced
this pull request
May 1, 2022
* Revert partial changes from #2483 Instead of using a low-level `is_ident` that only works on ascii characters. Instead match directly on the '_' character. The original functionality has been restored (using `isAlpha` instead). This commit removes the now unneccessary `is_ident` compat layer * Add regression test for unicode functions Co-authored-by: Pepe Iborra <pepeiborra@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sloorush
pushed a commit
to sloorush/haskell-language-server
that referenced
this pull request
May 21, 2022
* Revert partial changes from haskell#2483 Instead of using a low-level `is_ident` that only works on ascii characters. Instead match directly on the '_' character. The original functionality has been restored (using `isAlpha` instead). This commit removes the now unneccessary `is_ident` compat layer * Add regression test for unicode functions Co-authored-by: Pepe Iborra <pepeiborra@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
hololeap
pushed a commit
to hololeap/haskell-language-server
that referenced
this pull request
Aug 26, 2022
* Revert partial changes from haskell#2483 Instead of using a low-level `is_ident` that only works on ascii characters. Instead match directly on the '_' character. The original functionality has been restored (using `isAlpha` instead). This commit removes the now unneccessary `is_ident` compat layer * Add regression test for unicode functions Co-authored-by: Pepe Iborra <pepeiborra@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Names starting with
_is often used, for example, withlensamong many others. However, the current redundant import action does not remove those even when they are redundant.For instance,
Here,
_2is redundant, but GHCIDE does not give any actions. Adding one more redundant import likegives the action, but the action removes only
use, not_2.This PR resolves this issue.