Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hackage back to flake.nix #2652

Merged
merged 2 commits into from
Jan 29, 2022
Merged

Move hackage back to flake.nix #2652

merged 2 commits into from
Jan 29, 2022

Conversation

guibou
Copy link
Collaborator

@guibou guibou commented Jan 29, 2022 •
edited
Loading

Apparently flake-compat does not work correctly with local flake.

Reported by @teto and @smunix in #2621.

@guibou
Move hackage back to flake.nix
c49926e 
Apparently `flake-compat` does not work correctly with local flake.

Reported by @teto and @smunix in 2621.
@smunix
Copy link
Contributor

smunix commented Jan 29, 2022

Thanks @guibou! The issue is fixed indeed

@jneira jneira requested a review from berberman January 29, 2022 12:07
jneira
jneira approved these changes Jan 29, 2022
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you, and there is a report confirming the fix so merging

@jneira jneira added the merge me Label to trigger pull request merge label Jan 29, 2022
@mergify mergify bot merged commit ccce756 into haskell:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

@berberman berberman Awaiting requested review from berberman berberman is a code owner

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guibou @smunix @jneira