Enable support for 9.4 on windows #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wz1000
commented
Sep 1, 2022
•
wz1000
commented
- Revert "drop windows for 9.4.2"
- Fix entropy to 0.4.1.10 to fix build on windows
This reverts commit feeaa3c.
wz1000
requested review from
jneira,
Anton-Latukha and
Ailrun
as code owners
michaelpj
reviewed
Sep 1, 2022
wz1000
force-pushed
the
wip/hls-9.4-windows
branch
from
598d6ab
to
7cb3f7c
Compare
|
@guibou thanks for your help, but it seems like the Nix build is still failing, with a much worse error this time. I guess the last patch got merged because the Nix job is not required to merge. |
wz1000
force-pushed
the
wip/hls-9.4-windows
branch
from
a2fac97
to
0f7d5af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.