Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve formatting issues (stylish-haskell, pre-commit CI) #3171

Merged
merged 5 commits into from
Sep 18, 2022

Conversation

andys8
Copy link
Collaborator

@andys8 andys8 commented Sep 15, 2022

Because of the failing pre-commit hook #3170 a bunch of files are checked in, but not formatted as expected.

Note: The commit hook will still fail because of the first reason (stylish haskell parse errors, #3170)

Solves formatting issues

image

Solves some of the parse errors Currently results in ...

image

@andys8 andys8 changed the title Solve formatting issues Solve formatting issues (stylish-haskell) Sep 15, 2022
@kokobd
Copy link
Collaborator

kokobd commented Sep 15, 2022

Have you checked #3131 and #3145 out? Just in case the work is duplicated.

@andys8
Copy link
Collaborator Author

andys8 commented Sep 15, 2022

@kokobd I haven't. So thanks for the hint.

In case this PR is duplicated, I'm happy to close it ;)

@drsooch
Copy link
Collaborator

drsooch commented Sep 15, 2022

The closed PR I eventually found a file that needed a complete overhaul to remove the stylish Haskell error.

#3145 is intended to run just changes files to hopefully minimize the amount of formatting failures on CI. I have an approval but am going to try to remove the dependency on another action when I get some spare time.

@andys8 andys8 marked this pull request as draft September 15, 2022 13:51
@andys8
Copy link
Collaborator Author

andys8 commented Sep 15, 2022

e134351 addresses some of the parse issues, but not all. This PR could be overlapping / duplicating the work done in #3131. While this doesn't solve all issues, solving some of them and making sure the repository won't grow more issues with new PRs would be an improvement. So this PR or part of the work of #3131 could help.

@andys8 andys8 marked this pull request as ready for review September 15, 2022 14:50
@andys8 andys8 changed the title Solve formatting issues (stylish-haskell) Solve formatting issues (stylish-haskell, pre-commit CI) Sep 15, 2022
@andys8 andys8 force-pushed the improvement/solve-pre-commit-issues branch from e134351 to 50c7970 Compare September 16, 2022 17:59
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any downsides to merging this. Thanks!

@pepeiborra pepeiborra enabled auto-merge (squash) September 18, 2022 07:03
@pepeiborra pepeiborra merged commit b378de2 into haskell:master Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants