-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve formatting issues (stylish-haskell, pre-commit CI) #3171
Solve formatting issues (stylish-haskell, pre-commit CI) #3171
Conversation
@kokobd I haven't. So thanks for the hint.
In case this PR is duplicated, I'm happy to close it ;) |
The closed PR I eventually found a file that needed a complete overhaul to remove the stylish Haskell error. #3145 is intended to run just changes files to hopefully minimize the amount of formatting failures on CI. I have an approval but am going to try to remove the dependency on another action when I get some spare time. |
69edc9c
to
357c681
Compare
e134351 addresses some of the parse issues, but not all. This PR could be overlapping / duplicating the work done in #3131. While this doesn't solve all issues, solving some of them and making sure the repository won't grow more issues with new PRs would be an improvement. So this PR or part of the work of #3131 could help. |
* Env: Changing order (import) * Plugins: Dangling `$`
e134351
to
50c7970
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any downsides to merging this. Thanks!
Because of the failing pre-commit hook #3170 a bunch of files are checked in, but not formatted as expected.
Note: The commit hook will still fail because of the first reason (stylish haskell parse errors, #3170)
Solves formatting issues
Solves some of the parse errors Currently results in ...