SessionLoader: batch load #4439
Draft
+195
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor session loading to support multiple file paths **Body:** Enhanced session loading to handle multiple file paths, improving error handling and logging for cradle detection. Updated `packageSetup` and `session` functions to process lists of file paths, ensuring better component management. This change aims to improve the robustness and clarity of session initialization, especially in multi-component projects.
soulomoon
added
the
performance
…ility and consistency. This change enhances the clarity of the setup messages by properly formatting the list of cradles and log file paths.
This reverts commit d74ade7.
Refactor session loading to handle pending files Introduced a queue to manage pending files during session loading, ensuring that file options are processed in batches. This change improves the efficiency and reliability of session initialization by serializing file processing and avoiding redundant lookups. ```
Update cradle handling and hie-bios dependency Refactored cradle handling to use NonEmpty lists for better type safety and consistency. Updated hie-bios dependency to a new commit to incorporate recent fixes and improvements. Adjusted related functions to align with the new data structures and improved error handling. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #4381
Something bad: