Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build to ghc-8.10.2 and windows #619

Merged
merged 4 commits into from
Nov 24, 2020
Merged

Conversation

jneira
Copy link
Member

@jneira jneira commented Nov 24, 2020

Copy link
Collaborator

@ndmitchell ndmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of including this via exclude, why not use include: {os: windows, ghc: 8.10.2.2} and not put it in the matrix of GHC versions. That's what I'm doing in my projects.

@jneira
Copy link
Member Author

jneira commented Nov 24, 2020

@jneira
Copy link
Member Author

jneira commented Nov 24, 2020

We could take ride of other exclusions and use only inclusions but i somewhat like add explicitly cause we cant use those versions for windows (although the may be improved linking concrete issues f.e.)

@ndmitchell
Copy link
Collaborator

The other exclusions have information, so happy to have them around. The inclusion of a version that doesn't really exist is a bit different though, so I think include of 8.10.2.2 but exclude of others makes sense. But I'm not overly fussed.

@jneira jneira merged commit 420c6c5 into haskell:master Nov 24, 2020
@jneira jneira deleted the win-build-8.10.2 branch January 15, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants