Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing 2.6.3.5 #312

Closed
3 tasks done
kazu-yamamoto opened this issue Mar 9, 2018 · 10 comments
Closed
3 tasks done

Releasing 2.6.3.5 #312

kazu-yamamoto opened this issue Mar 9, 2018 · 10 comments

Comments

@kazu-yamamoto
Copy link
Collaborator

kazu-yamamoto commented Mar 9, 2018

Cc @eborden @glguy

It appeared that fixing #271 is too radical for 2.6.3.4. MIN_VERSION_network cannot capture this change. It should be done in 2.7.0.0.

@eborden
Copy link
Collaborator

eborden commented Mar 9, 2018

This sounds like a reasonable path.

@kazu-yamamoto
Copy link
Collaborator Author

@eborden Reverting and bump-up is done. We can release 2.6.3.5 whenever you like.

@kazu-yamamoto
Copy link
Collaborator Author

We should resolve #313 before releasing 2.6.3.5.

@kazu-yamamoto
Copy link
Collaborator Author

@eborden May I ask you to release 2.6.3.5 now?
#313 is messy.
Now I believe that we should not wait for fixing it because we cannot reproduce it yet.
One case of AppVeyor did not pass.
But I do believe that is due to a bug of test framework.

@kazu-yamamoto
Copy link
Collaborator Author

Ping @eborden

@eborden
Copy link
Collaborator

eborden commented Mar 27, 2018

I'll put up a candidate tonight.

@eborden
Copy link
Collaborator

eborden commented Mar 27, 2018

Candidate uploaded here: https://hackage.haskell.org/package/network-2.6.3.5/candidate

@eborden
Copy link
Collaborator

eborden commented Mar 28, 2018

Candidate released.

Cafe message sent:

Announcing network-2.6.3.5

  • Reverting "Do not closeFd within sendFd"
    #271

Sorry for any disruption this versioning snafu may have caused.

https://hackage.haskell.org/package/network-2.6.3.5

@eborden
Copy link
Collaborator

eborden commented Mar 28, 2018

2.6.3.4 has been deprecated
image

@eborden eborden closed this as completed Mar 28, 2018
@kazu-yamamoto
Copy link
Collaborator Author

@eborden Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants