For 2.7.0.0 #310
Merged
For 2.7.0.0 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module has been kept for backwards compatibility for a long time. It has been unnoficially deprecated via documentation for a long time (since 2014), but has never been given a proper deprecation flag. This flag signals that using this module is an error and should be avoided, something that can easily be missed by not reading the module summary.
We introduced warnings on `String` based functions in 2016. It seems reasonable to upgrade these warnings to `DEPRECATED`. The eventual goal here would be to remove these functions in a major epoch like 3.0.0.0.
eborden
requested changes
Mar 9, 2018
Network/Socket/Types.hsc
Outdated
| @@ -191,6 +184,8 @@ packSocketType' stype = case Just stype of | |||
| #endif | |||
| _ -> Nothing | |||
|
|
|||
| {-# DEPRECATED packSocketType "Don't use this" #-} | |||
There was a problem hiding this comment.
Could we get some reasoning in place for these "Don't use this" messages? Why shouldn't we use them?
There was a problem hiding this comment.
Could you clean up the other instances of "Don't use this"?
There was a problem hiding this comment.
OK. I changed three "Don't use this".
|
@eborden Ping. |
eborden
approved these changes
Mar 22, 2018
|
Merged. Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.7branch is now2.7-old2.7was created on2.6(They point the same commit at this moment)This PR is to recover
2.7based on2.6.No deletions. Deprecations only.
Some APIs should be implemented or fixed as discussed in #296 before we release v2.7.0.0.