Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode-languageclient to 7.0.0 #424

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

berberman
Copy link
Collaborator

Tested on my machine, this could fix haskell/haskell-language-server#2068.

@jneira
Copy link
Member

jneira commented Aug 5, 2021

nice, good catch, only a bit worried in case users has not upgrade their editors (for whatever reason)
is this the lastest one? did you have to upgrade your client?

@berberman
Copy link
Collaborator Author

The version 1.52.0 is from the lsp extension guide (https://code.visualstudio.com/api/language-extensions/language-server-extension-guide), and it's the latest version. Maybe an older vscode can work, which at least should include the support of semantic tokens. I don't know what the exact bound is, but imho people should always keep their editors up-to-date.

By specifying engines.vscode: "^1.52.0", the extension won't be loaded if a user's vscode version is older than that.

@jneira jneira merged commit ae8056c into haskell:master Aug 6, 2021
@pepeiborra
Copy link
Contributor

@berberman did you confirm that this fixes haskell/haskell-language-server#2068 ?

@berberman
Copy link
Collaborator Author

@berberman did you confirm that this fixes haskell/haskell-language-server#2068 ?

Yes, at least on my laptop

@berberman berberman deleted the languageclient-7.0 branch August 6, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to initialize lsp server in vscode
3 participants