Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vscode-languageclient from 7.0.0 to 8.1.0 #857

Merged
merged 3 commits into from
Jul 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@
],
"dependencies": {
"ts-pattern": "^4.2.2",
"vscode-languageclient": "^7.0.0",
"vscode-languageclient": "^8.1.0",
"which": "^3.0.1"
}
}
5 changes: 2 additions & 3 deletions src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {
Logger,
RevealOutputChannelOn,
ServerOptions,
TransportKind,
} from 'vscode-languageclient/node';
import { RestartServerCommandName, StartServerCommandName, StopServerCommandName } from './commands/constants';
import * as DocsBrowser from './docsBrowser';
Expand Down Expand Up @@ -236,8 +235,8 @@ async function activateServerForFolder(context: ExtensionContext, uri: Uri, fold
// For our intents and purposes, the server should be launched the same way in
// both debug and run mode.
const serverOptions: ServerOptions = {
run: { command: serverExecutable, transport: TransportKind.stdio, args, options: exeOptions },
debug: { command: serverExecutable, transport: TransportKind.stdio, args, options: exeOptions },
run: { command: serverExecutable, args, options: exeOptions },
debug: { command: serverExecutable, args, options: exeOptions },
fendor marked this conversation as resolved.
Show resolved Hide resolved
};

logger.info(`run command: ${serverExecutable} ${args.join(' ')}`);
Expand Down
3 changes: 1 addition & 2 deletions src/hlsBinaries.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import * as child_process from 'child_process';
import { ExecException } from 'child_process';
import * as fs from 'fs';
import { stat } from 'fs/promises';
import * as https from 'https';
Expand Down Expand Up @@ -34,7 +33,7 @@ const exeExt = process.platform === 'win32' ? '.exe' : '';
* Callback invoked on process termination.
*/
type ProcessCallback = (
error: ExecException | null,
error: child_process.ExecFileException | null,
stdout: string,
stderr: string,
resolve: (value: string | PromiseLike<string>) => void,
Expand Down
Loading