Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add haskell.plugin.fourmolu.config.path option #987

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

georgefst
Copy link
Contributor

Companion to haskell/haskell-language-server#3860. Shouldn't be merged until that is.

The added lines come from manually inspecting the output of cabal run exe:haskell-language-server vscode-extension-schema. Do we have a better automatic process for this (I'm sure it'd be fairly easy to script with jq, perhaps after an initial commit re-ordering things)?

@fendor
Copy link
Collaborator

fendor commented Nov 6, 2023

Do we have a better automatic process for this

We don't, unfortunately :(
The output of HLS should be sorted already, so I just copy and paste it in.

What makes this task especially tedious, you need to be careful to run vscode-extension-schema with a HLS binary that supports all plugins, otherwise some entries will be missing, since vscode-extension-schema depends on the installed plugins.
We had an idea to decouple the plugin from its configuration to fix this, but no one got around to it, yet.

@fendor fendor marked this pull request as ready for review March 11, 2024 08:34
@fendor fendor merged commit dd201a4 into haskell:master Mar 11, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants