Remove deprecated websocket config #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The thing I wanted to do on #287, is removing NGINX? I think that isn't needed anymore... ../Frenck |
|
If I am not wrong, after the removal of the websocket bits, the local SSL config option seems to be the last nginx "feature". While not using it myself locally, I am uncertain how much it is used or requested. Could be important to some. Let me know if I can be of any help, or close this PR. Luckily, didn't take too much time ;-) |
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
stale
That is a really good point actually. As one would need to be able to enable SSL in those cases... |
frenck
added
stale
frenck
force-pushed
the
remove-ws-config
branch
from
1e6a8ea to
73dbc78
Compare
frenck
approved these changes
Jan 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Vaultwarden enables websockets on the backend port by default, and no longer requires the websocket config (since v1.29.0). In addition, with v1.31.0, the websocket config will become deprecated. See also:
This PR removes the websocket config from nginx and the vaultwarden run script.
Related Issues
No issues yet.