Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Adds Websockets support #9

Merged
merged 5 commits into from
Dec 3, 2019
Merged

✨ Adds Websockets support #9

merged 5 commits into from
Dec 3, 2019

Conversation

reharmsen
Copy link
Contributor

Proposed Changes

These changes enable Websockets support of Bitwarden_RS

Related Issues

none

@addons-assistant
Copy link

💖 Thanks for opening this pull request! 💖 If your PR gets accepted and merged in, we will invite you to the project 🎉

@frenck
Copy link
Member

frenck commented Oct 31, 2019

Have you actually tested this? It seems like a driveby using GitHub's edit function...

@reharmsen
Copy link
Contributor Author

I did not....

Can i find any guide on how to get things up for testing?

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this in and debug afterwards.

Thanks 👍

@frenck frenck changed the title Enable Websockets support ✨ Adds Websockets support Dec 3, 2019
@frenck frenck merged commit baaef0b into hassio-addons:master Dec 3, 2019
@addons-assistant
Copy link

Congrats on merging your first pull request! 🎉🎉🎉

@addons-assistant
Copy link

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@addons-assistant addons-assistant bot locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants