Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git diff terminal colors not working #30

Closed
fllaca opened this issue Aug 5, 2018 · 4 comments
Closed

git diff terminal colors not working #30

fllaca opened this issue Aug 5, 2018 · 4 comments

Comments

@fllaca
Copy link

fllaca commented Aug 5, 2018

Problem/Motivation

(Why the issue was filed)

As stated in home-assistant/supervisor#343, git diff shows bad colouring (In my case when using a git repo to store homeassistant configuration).

Expected behavior

(What you expected to happen)

Git diff shows output with nice colours:
imagen

Actual behavior

(What actually happened)
Git output shows uggly codes:

imagen

Steps to reproduce

(How can someone else make/see it happen)
Use git repo to store configuration:

# ssh into hassio:
cd /config
git init
git add .
git commit -m "initial commit"

Then, make some changes:

cd /config
# change something:
vi configuration.yaml 

# This shows bad colours:
git diff

Proposed changes

(If you have a proposed change, workaround or fix,
describe the rationale behind it)

Following @jkeljo advice in home-assistant/supervisor#343, installing a more feature version of less fixes it: apk --no-cache add less

@addons-assistant
Copy link

👋 Thanks for opening your first issue here! If you're reporting a 🐛 bug, please make sure you include steps to reproduce it. Also, logs, error messages and information about your hardware might be usefull.

@fllaca
Copy link
Author

fllaca commented Aug 5, 2018

I've made a PR with a fix for this: #31

@frenck
Copy link
Member

frenck commented Aug 12, 2018

Added in v3.3.0! 🎉

@frenck frenck closed this as completed Aug 12, 2018
@addons-assistant
Copy link

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@addons-assistant addons-assistant bot locked as resolved and limited conversation to collaborators Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants