Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make subscription not exists error non-dynamic #83

Merged

Conversation

sermojohn
Copy link

@sermojohn sermojohn commented Mar 27, 2023

This PR will help clients identify this error without matching on the error message.

errors.Is(err, ErrSubscriptionNotExists) can be used for querying that specific error and handling it separately.

Additionally, the typo of the original error message is fixed :)

Copy link

@hgiasac hgiasac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM.

@hgiasac hgiasac merged commit a77eb8c into hasura:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants