-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli(installer): add -f flag to curl (fix #1871) #3477
Conversation
Beep boop! 🤖 Hey @ashishra0, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. Stay awesome! 😎 |
Deploy preview for hasura-docs ready! Built with commit ad55b4d |
Review app for commit 72d7985 deployed to Heroku: https://hge-ci-pull-3477.herokuapp.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashishra0 Will you add the flag to add curl
commands in this script?
all the curl commands in the script? |
Review app for commit ad55b4d deployed to Heroku: https://hge-ci-pull-3477.herokuapp.com |
Beep boop! 🤖 Awesome work @ashishra0! All of us at Hasura ❤️ what you did. Thanks again 🤗 |
Review app https://hge-ci-pull-3477.herokuapp.com is deleted |
Related Issues
#1871
Solution and Design
By adding the -f flag to curl we can check if the response received was 200.