Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli(installer): add -f flag to curl (fix #1871) #3477

Merged
merged 2 commits into from
Dec 12, 2019
Merged

cli(installer): add -f flag to curl (fix #1871) #3477

merged 2 commits into from
Dec 12, 2019

Conversation

ashishra0
Copy link
Contributor

@ashishra0 ashishra0 commented Dec 4, 2019 •
edited
Loading

Related Issues

#1871

Solution and Design

By adding the -f flag to curl we can check if the response received was 200.

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @ashishra0, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

@claassistantio
Copy link

claassistantio commented Dec 4, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Dec 4, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit ad55b4d

https://deploy-preview-3477--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit 72d7985 deployed to Heroku: https://hge-ci-pull-3477.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3477-72d7985f

shahidhk
shahidhk requested changes Dec 5, 2019
View reviewed changes
Copy link
Member

@shahidhk shahidhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashishra0 Will you add the flag to add curl commands in this script?

@ashishra0
Copy link
Contributor Author

@ashishra0 Will you add the flag to add curl commands in this script?

all the curl commands in the script?

@hasura-bot
Copy link
Contributor

Review app for commit ad55b4d deployed to Heroku: https://hge-ci-pull-3477.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3477-ad55b4d0

@shahidhk shahidhk changed the title add -f flag to curl (fix #1871) cli(installer): add -f flag to curl (fix #1871) Dec 12, 2019
@shahidhk shahidhk added the c/cli Related to CLI label Dec 12, 2019
@shahidhk shahidhk merged commit 0f89940 into hasura:master Dec 12, 2019
@hasura-bot
Copy link
Contributor

Beep boop! 🤖

GIF

Awesome work @ashishra0! All of us at Hasura ❤️ what you did.

Thanks again 🤗

@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3477.herokuapp.com is deleted

polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@ashishra0 @polRk
cli(installer): add -f flag to curl (fix hasura#1871) (hasura#3477)
1166353
@sumodgeorge sumodgeorge mentioned this pull request Nov 28, 2023
Open
@Allymahmoud Allymahmoud mentioned this pull request Nov 28, 2023
Open
@ptakpatryk ptakpatryk mentioned this pull request Dec 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahidhk shahidhk shahidhk approved these changes

Assignees
No one assigned
Labels
c/cli Related to CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashishra0 @hasura-bot @claassistantio @shahidhk