-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli(build): migrate to go modules (close #3476) #3493
Conversation
Beep boop! 🤖 Hey @ashishra0, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. Stay awesome! 😎 |
Deploy preview for hasura-docs ready! Built with commit be102fb |
Review app for commit 2e3a5a3 deployed to Heroku: https://hge-ci-pull-3493.herokuapp.com |
Review app for commit 151a1a7 deployed to Heroku: https://hge-ci-pull-3493.herokuapp.com |
Review app for commit 27b8485 deployed to Heroku: https://hge-ci-pull-3493.herokuapp.com |
Review app for commit 6ac5981 deployed to Heroku: https://hge-ci-pull-3493.herokuapp.com |
Review app for commit 24f4ca2 deployed to Heroku: https://hge-ci-pull-3493.herokuapp.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashishra0 Let's also run go mod tidy
to make sure the packages are correct.
cli/go.mod
Outdated
@@ -0,0 +1,69 @@ | |||
module github.com/ashishra0/graphql-engine/tree/master/cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module github.com/ashishra0/graphql-engine/tree/master/cli | |
module github.com/hasura/graphql-engine/cli |
HAS_BINDATA := $(shell command -v go-bindata;) | ||
|
||
.PHONY: deps | ||
# get dependencies | ||
deps: | ||
ifndef HAS_DEP | ||
go get -u github.com/golang/dep/cmd/dep | ||
endif | ||
ifndef HAS_GOX | ||
go get github.com/mitchellh/gox | ||
endif | ||
ifndef HAS_BINDATA | ||
go get github.com/hasura/go-bindata/go-bindata | ||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add go mod download
as a step to pre-download packages under make deps
Review app for commit f7953ed deployed to Heroku: https://hge-ci-pull-3493.herokuapp.com |
Review app for commit be102fb deployed to Heroku: https://hge-ci-pull-3493.herokuapp.com |
Beep boop! 🤖 Awesome work @ashishra0! All of us at Hasura ❤️ what you did. Thanks again 🤗 |
Review app https://hge-ci-pull-3493.herokuapp.com is deleted |
Description
(close #3476)
Remove go dependency management tool. Added Go modules as a dependency management tool.
go dep from Makefile is removed and the Contributing.md is updated as well.
Affected components