console: remove postinstall script from package.json #5630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beerose
approved these changes
Aug 20, 2020
tirumaraiselvan
approved these changes
Aug 20, 2020
|
Review app https://hge-ci-pull-5630.herokuapp.com is deleted |
stevefan1999-personal
pushed a commit
to stevefan1999-personal/graphql-engine
that referenced
this pull request
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is this postinstall script that just shows if there are any errors in the bundle. In most cases there are no errors, so it just wastes 30ish seconds. In case of errors, the following script (
npm run devornpm run build) will throw an error anyway, so this script is unnecessary.Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.Affected components