Support Postgres POSIX regex operators close #4317 #6172

christophediprima · 2020-11-11T08:25:01Z

Description

Add support for following Postgres operators:

_regex: ~
_iregex: ~*
_nregex: !~
_niregex: !~*

Changelog

CHANGELOG.md is updated with user-facing content relevant to this PR.

Affected components

Related Issues

#4317

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

No

Metadata

Does this PR add a new Metadata feature?

No

GraphQL

New GraphQL schema is being generated:
- New fields in String_comparison_exp

Breaking changes

No Breaking changes

hasura-bot · 2020-11-11T08:25:04Z

Beep boop! 🤖

Hey @christophediprima, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible.

Stay awesome! 😎

CLAassistant · 2020-11-11T08:25:07Z

All committers have signed the CLA.

netlify · 2020-11-11T08:26:31Z

Deploy preview for hasura-docs ready!

Built with commit 327abfc

https://deploy-preview-6172--hasura-docs.netlify.app

christophediprima · 2020-11-11T08:27:07Z

This is my first pull request. It is not fully completed yet. Any comment or help to complete it is welcome :)

abooij · 2020-11-11T11:34:59Z

@christophediprima You can indicate that the PR is not yet ready for review by putting it in a "draft" state. You can do it before you open it, or, for this PR which is already open, click "Convert to draft" on the right-hand side under the "Reviewers" section.

christophediprima · 2020-11-13T09:47:52Z

@abooij I think I am done with the code. Could you help me with the PR remaining checks? I am not sure if they are yes or no.

christophediprima · 2020-11-20T10:41:54Z

@abooij how long do you think it could take to be integrated into a new version?

abooij · 2020-11-21T17:03:35Z

Hey @christophediprima! Sorry, I missed your message from last week. Thanks for reminding me, I'll have a look at this PR on Monday.

abooij

Thanks for this PR, @christophediprima. The Haskell code has been developed very nicely, following the pattern of the other operators accurately. I have no substantial comments on the code itself. Please add one comment for future reference (since this work is overlapping some other work that's currently taking place, and needs to be coordinated somewhat). And I've attempted to improve some test descriptions somewhat.

@beerose, who could review the console part of this PR?

@marionschleifer, could you review the docs for this?

@tirumaraiselvan, could you please review the changelog?

server/tests-py/queries/graphql_query/boolexp/search/select_city_where_not_posix_ci.yaml

server/tests-py/queries/graphql_query/boolexp/search/select_city_where_not_posix_cs.yaml

server/tests-py/queries/v1/select/boolexp/search/select_city_where_not_posix_ci.yaml

server/tests-py/queries/v1/select/boolexp/search/select_city_where_not_posix_cs.yaml

server/src-lib/Hasura/RQL/IR/BoolExp.hs

beerose

Thanks for the PR!
Approving console changes.

marionschleifer

Docs 👍

CHANGELOG.md

console/src/components/Common/FilterQuery/types.ts

server/tests-py/test_v1_queries.py

tirumaraiselvan

Thanks for the wonderful PR but I think we should use regex as the base operator name and also use the existing conventions for "not" and "case insensitivity" for the derived operators: https://github.com/hasura/graphql-engine/pull/6172/files#r530185924

CHANGELOG.md

abooij · 2020-11-25T11:19:24Z

@christophediprima

Should I keep resolving conflicts on CHANGELOG.md @abooij? Or will @tirumaraiselvan take care of this? sweat_smile

As a rule of thumb, during the review phase of a PR, it's not necessary to resolve every conflict, especially e.g. in the changelog. If there are any substantial conflicts, e.g. another PR has been merged that touches a lot of the same code, then it would be wise to resolve the conflict even before your PR is accepted, so that your PR doesn't go out of date too much.

When you do resolve conflicts, in this repository we prefer that you do so using merge commits rather than rebases and force-pushes, since:

we end up squashing the entire PR anyway
this way we can see how you resolved certain conflicts, and how you are responding to review comments, etc.

simplify changelog remove cli-ext script fix

tirumaraiselvan

@christophediprima Thank you. Just the final minor thing: can you revert the changes to cli-ext/package.json and cli-ext/tests/sdl/payload.js files so they are out of this changeset. I think it's just a lint change.

christophediprima · 2020-11-25T20:16:38Z

@tirumaraiselvan cli-ext/tests/sdl/payload.jshas some changes. I fixed the linting issue.

christophediprima · 2020-11-26T08:56:22Z

@tirumaraiselvan do I still have to do something or is everything ok? :)

abooij · 2020-11-26T09:02:08Z

@christophediprima Congrats, all lights are green! We'll take this up and let you know if there's anything else you can do.

hasura-bot · 2020-11-27T10:54:59Z

Thanks for your contribution! Your changes have been merged successfully.

Co-authored-by: christophediprima <dipdipdip84@gmail.com> Co-authored-by: dip <dipdipdip84@gmail.com> Co-authored-by: Auke Booij <auke@hasura.io> Co-authored-by: Antoine Leblanc <antoine@hasura.io> GITHUB_PR_NUMBER: 6172 GITHUB_PR_URL: #6172 GitOrigin-RevId: 5192d23

abooij · 2020-11-27T11:02:27Z

@christophediprima: @hasura-bot seems to have been confused momentarily about your PR, but rest assured it was merged successfully!

christophediprima requested review from a team as code owners November 11, 2020 08:25

christophediprima marked this pull request as draft November 11, 2020 12:20

christophediprima force-pushed the 4317-posix-operators branch 2 times, most recently from ee1c66c to d1f0ec8 Compare November 12, 2020 17:18

christophediprima marked this pull request as ready for review November 12, 2020 17:21

christophediprima requested a review from a team as a code owner November 12, 2020 17:21

christophediprima force-pushed the 4317-posix-operators branch 4 times, most recently from ea37fd2 to 6e3b6cc Compare November 13, 2020 09:04

abooij reviewed Nov 23, 2020

View reviewed changes

abooij added c/console Related to console c/docs Related to docs c/server Related to server community-contrib 🙏🏽 labels Nov 23, 2020

beerose self-requested a review November 23, 2020 12:03

beerose approved these changes Nov 23, 2020

View reviewed changes

abooij approved these changes Nov 23, 2020

View reviewed changes

marionschleifer approved these changes Nov 23, 2020

View reviewed changes

Antoine Leblanc and others added 2 commits November 24, 2020 09:14

add support for POSIX operators

0db7d9d

add POSIX operators to changelog

d5be287

tirumaraiselvan reviewed Nov 25, 2020

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

tirumaraiselvan reviewed Nov 25, 2020

View reviewed changes

console/src/components/Common/FilterQuery/types.ts Outdated Show resolved Hide resolved

tirumaraiselvan reviewed Nov 25, 2020

View reviewed changes

server/tests-py/test_v1_queries.py Show resolved Hide resolved

tirumaraiselvan requested changes Nov 25, 2020

View reviewed changes

tirumaraiselvan reviewed Nov 25, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

christophediprima added 5 commits November 25, 2020 13:36

rename operators to use regex

327abfc

simplify changelog remove cli-ext script fix

fix operators name

3c94478

fix test paths

e1f533b

add missing tests

f3307c8

add iregex permission test

d14a419

christophediprima requested a review from tirumaraiselvan November 25, 2020 18:12

tirumaraiselvan requested changes Nov 25, 2020

View reviewed changes

christophediprima added 3 commits November 25, 2020 21:04

fix linting

8402123

fix linting

542b205

fix linting

3d3db7c

christophediprima requested a review from tirumaraiselvan November 25, 2020 20:15

tirumaraiselvan approved these changes Nov 26, 2020

View reviewed changes

tirumaraiselvan changed the title ~~Support Postgres POSIX operators close #4317~~ Support Postgres POSIX regex operators close #4317 Nov 26, 2020

Merge branch 'master' into 4317-posix-operators

e291da7

hasura-bot closed this Nov 27, 2020

hasura-bot added the merged label Nov 27, 2020

christophediprima deleted the 4317-posix-operators branch November 27, 2020 13:22

sumodgeorge mentioned this pull request Jan 6, 2024

[Snyk] Security upgrade axios from 0.27.2 to 1.6.4 sumodgeorge/graphql-engine#63

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Postgres POSIX regex operators close #4317 #6172

Support Postgres POSIX regex operators close #4317 #6172

christophediprima commented Nov 11, 2020 •

edited by tirumaraiselvan

Loading

hasura-bot commented Nov 11, 2020

CLAassistant commented Nov 11, 2020 •

edited

Loading

netlify bot commented Nov 11, 2020 •

edited

Loading

christophediprima commented Nov 11, 2020

abooij commented Nov 11, 2020

christophediprima commented Nov 13, 2020 •

edited

Loading

christophediprima commented Nov 20, 2020

abooij commented Nov 21, 2020

abooij left a comment

beerose left a comment

marionschleifer left a comment

tirumaraiselvan left a comment

abooij commented Nov 25, 2020

tirumaraiselvan left a comment •

edited

Loading

christophediprima commented Nov 25, 2020

christophediprima commented Nov 26, 2020

abooij commented Nov 26, 2020

hasura-bot commented Nov 27, 2020

abooij commented Nov 27, 2020

Support Postgres POSIX regex operators close #4317 #6172

Support Postgres POSIX regex operators close #4317 #6172

Conversation

christophediprima commented Nov 11, 2020 • edited by tirumaraiselvan Loading

Description

Changelog

Affected components

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Metadata

GraphQL

Breaking changes

hasura-bot commented Nov 11, 2020

CLAassistant commented Nov 11, 2020 • edited Loading

netlify bot commented Nov 11, 2020 • edited Loading

christophediprima commented Nov 11, 2020

abooij commented Nov 11, 2020

christophediprima commented Nov 13, 2020 • edited Loading

christophediprima commented Nov 20, 2020

abooij commented Nov 21, 2020

abooij left a comment

Choose a reason for hiding this comment

beerose left a comment

Choose a reason for hiding this comment

marionschleifer left a comment

Choose a reason for hiding this comment

tirumaraiselvan left a comment

Choose a reason for hiding this comment

abooij commented Nov 25, 2020

tirumaraiselvan left a comment • edited Loading

Choose a reason for hiding this comment

christophediprima commented Nov 25, 2020

christophediprima commented Nov 26, 2020

abooij commented Nov 26, 2020

hasura-bot commented Nov 27, 2020

abooij commented Nov 27, 2020

christophediprima commented Nov 11, 2020 •

edited by tirumaraiselvan

Loading

CLAassistant commented Nov 11, 2020 •

edited

Loading

netlify bot commented Nov 11, 2020 •

edited

Loading

christophediprima commented Nov 13, 2020 •

edited

Loading

tirumaraiselvan left a comment •

edited

Loading