Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user-agent to request header #258

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Add user-agent to request header #258

merged 1 commit into from
Jul 10, 2023

Conversation

Chocobo1
Copy link
Contributor

@Chocobo1 Chocobo1 commented Jul 9, 2023

Quote from https://www.rfc-editor.org/rfc/rfc9110#name-user-agent:

A user agent SHOULD send a User-Agent header field in each request unless specifically configured not to do so.

Closes #257.

@Chocobo1 Chocobo1 force-pushed the user-agent branch 2 times, most recently from 87302bc to b6859a0 Compare July 9, 2023 18:04
@hatoo
Copy link
Owner

hatoo commented Jul 10, 2023

@Chocobo1
LGTM!

Could you apply rustfmt (just run cargo fmt)?
I'll merge after that. Thanks!

Quote from https://www.rfc-editor.org/rfc/rfc9110#name-user-agent:
> A user agent SHOULD send a User-Agent header field in each request
> unless specifically configured not to do so.

Closes hatoo#257.
@Chocobo1
Copy link
Contributor Author

Could you apply rustfmt (just run cargo fmt)?
I'll merge after that. Thanks!

OK, done.

@hatoo hatoo merged commit 186d800 into hatoo:master Jul 10, 2023
38 checks passed
@Chocobo1 Chocobo1 deleted the user-agent branch July 10, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add user-agent header
2 participants