Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create zh.json #691

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Create zh.json #691

wants to merge 3 commits into from

Conversation

shayzluf
Copy link
Collaborator

@shayzluf shayzluf commented May 22, 2024

Summary by CodeRabbit

  • New Features
    • Added a new language file zh.json to the app with support for Chinese language.

Copy link
Contributor

coderabbitai bot commented May 22, 2024

Walkthrough

This update introduces a new language file zh.json, enhancing language support by adding Chinese (zh) alongside existing English (en) and Japanese (jp) files in the project's language module.

Changes

Files/Directories Change Summary
packages/web/src/languages/index.ts Added zh.json to the languages object.

Poem

Code in languages three,
En, jp, now zh, you see.
CodeRabbit's touch, a global flight,
In bytes of languages, a beautiful sight.
New horizons in code's domain,
With each addition, a world to gain.
🐇🌏


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between f448abf and e30318e.
Files selected for processing (1)
  • packages/web/src/languages/zh.json (1 hunks)
Files not summarized due to errors (1)
  • packages/web/src/languages/zh.json: Error: Message exceeds token limit
Additional comments not posted (1)
packages/web/src/languages/zh.json (1)

1-1462: Ensure JSON structure is well-formed and translations are consistent.

This JSON file appears to be well-formed with no syntax errors or duplicate keys. The translations seem consistent and appropriate for the intended audience.

Copy link

cloudflare-workers-and-pages bot commented May 22, 2024

Deploying dapp with  Cloudflare Pages  Cloudflare Pages

Latest commit: d36df13
Status: ✅  Deploy successful!
Preview URL: https://407b1a45.dapp-a9y.pages.dev
Branch Preview URL: https://chinese-try-1.dapp-a9y.pages.dev

View logs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between e30318e and 88b03d0.
Files selected for processing (1)
  • packages/web/src/languages/index.ts (1 hunks)
Additional comments not posted (1)
packages/web/src/languages/index.ts (1)

6-6: Ensure the import statement for zh is corrected before using it here.

Once the import statement is fixed as suggested, this line will correctly add the zh localization to the project.

@@ -1,6 +1,8 @@
import en from "./en.json";
import jp from "./jp.json";
import jp from "./zh.json";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the import statement for zh.json.

- import jp from "./zh.json";
+ import zh from "./zh.json";

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
import jp from "./zh.json";
import zh from "./zh.json";

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 88b03d0 and d36df13.
Files selected for processing (1)
  • packages/web/src/languages/index.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • packages/web/src/languages/index.ts

@fonstack fonstack marked this pull request as draft June 18, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant