-
Notifications
You must be signed in to change notification settings - Fork 30
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
allow reference string to be passed to AddArtifact instead of name.Pa…
…rseReference for ease of use, move reference validation within AddArtifact
- Loading branch information
Showing
8 changed files
with
48 additions
and
249 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,73 +1 @@ | ||
package chart_test | ||
|
||
import ( | ||
"context" | ||
"os" | ||
"path" | ||
"testing" | ||
|
||
"github.com/google/go-containerregistry/pkg/name" | ||
|
||
"github.com/rancherfederal/hauler/pkg/apis/hauler.cattle.io/v1alpha1" | ||
"github.com/rancherfederal/hauler/pkg/content/chart" | ||
"github.com/rancherfederal/hauler/pkg/log" | ||
"github.com/rancherfederal/hauler/pkg/store" | ||
) | ||
|
||
func TestChart_Copy(t *testing.T) { | ||
ctx := context.Background() | ||
l := log.NewLogger(os.Stdout) | ||
ctx = l.WithContext(ctx) | ||
|
||
tmpdir, err := os.MkdirTemp("", "hauler") | ||
if err != nil { | ||
t.Error(err) | ||
} | ||
defer os.Remove(tmpdir) | ||
|
||
s, err := store.NewStore(tmpdir) | ||
if err != nil { | ||
t.Error(err) | ||
} | ||
|
||
type args struct { | ||
ctx context.Context | ||
registry string | ||
} | ||
tests := []struct { | ||
name string | ||
cfg v1alpha1.Chart | ||
args args | ||
wantErr bool | ||
}{ | ||
// TODO: This test isn't self-contained | ||
{ | ||
name: "should work with unversioned chart", | ||
cfg: v1alpha1.Chart{ | ||
Name: "loki", | ||
RepoURL: "https://grafana.github.io/helm-charts", | ||
}, | ||
args: args{ | ||
ctx: ctx, | ||
registry: "", | ||
}, | ||
wantErr: false, | ||
}, | ||
} | ||
for _, tt := range tests { | ||
t.Run(tt.name, func(t *testing.T) { | ||
c, err := chart.NewChart(tt.cfg.Name, tt.cfg.RepoURL, tt.cfg.Version) | ||
if err != nil { | ||
t.Fatal(err) | ||
} | ||
ref, err := name.ParseReference(path.Join("hauler", tt.cfg.Name)) | ||
if err != nil { | ||
t.Fatal(err) | ||
} | ||
|
||
if _, err := s.AddArtifact(ctx, c, ref); (err != nil) != tt.wantErr { | ||
t.Error(err) | ||
} | ||
}) | ||
} | ||
} |
Oops, something went wrong.