Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed hauler login typo #299

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Conversation

zackbradys
Copy link
Member

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

  • N/A

Types of Changes:

  • Bugfix

Proposed Changes:

  • Updated hauler login to change BoolVarP to BoolVar due to typo/no shorthand flag for --password-stdin

Verification/Testing of Changes:

  • Clone the repository and locally build hauler and run hauler login

Additional Context:

  • N/A

@zackbradys zackbradys self-assigned this Aug 20, 2024
@zackbradys zackbradys added bug Something isn't working size/S Denotes an issue/PR requiring a relatively small amount of work labels Aug 20, 2024
@zackbradys zackbradys added this to the Hauler v1.1.0 milestone Aug 20, 2024
@zackbradys zackbradys requested a review from a team August 20, 2024 04:26
@zackbradys zackbradys changed the title Fixed hauler login typo fixed hauler login typo Aug 20, 2024
Copy link
Contributor

@atoy3731 atoy3731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM.

[09:10:38] /tmp/hauler/bin [fixed-hauler-login-typo] $ echo 'REDACTED' | ./hauler login REDACTED -u user --password-stdin
2024-08-23 09:10:44 INF auth.go:274: logged in via /Users/REDACTED/.docker/config.json
[09:10:44] /tmp/hauler/bin [fixed-hauler-login-typo] $ hauler store add image REDACTED/REDACTED:REDACTED
2024-08-23 09:10:45 INF adding 'image' [REDACTED/REDACTED:REDACTED] to the store
2024-08-23 09:10:50 INF successfully added 'image' [REDACTED/REDACTED:REDACTED]

@atoy3731 atoy3731 merged commit d6b3c94 into hauler-dev:main Aug 23, 2024
1 check passed
@zackbradys zackbradys deleted the fixed-hauler-login-typo branch August 23, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes an issue/PR requiring a relatively small amount of work
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

2 participants