Make content types pubic, expose configuration fields #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikkelma
force-pushed
the
public-content-types
branch
from
2dd923c
to
40fb078
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow content to be used publicly outside of the hauler package. Add fields reflecting the creation parameters to more clearly inherit functionality confirmed by unit tests.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature / refactor
What is the current behavior? (You can also link to an open issue here)
Types that implement the
OCIinterface forContentobjects are private and hard to use in unit test contexts.What is the new behavior (if this is a feature change)?
Publicly exposes types that implement the
OCIinterface forContentAPI objects, and adds fields these types to more easily inherit unit test guarantees.