-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trio to projects list #111
Conversation
[snip] I think I misinterpreted default mode of mypy primer. Ignore! |
Would it make sense to add this library for pyright as well? Pyright is referenced in the |
We don't run pyright over the codebase (the perils of type checker compatibility) but we do have "type tests" we run both mypy and pyright over -- would that be a valuable addition? |
I think it would be a valuable addition regardless. Mypy_primer emits deltas, and it's useful to know about any changes to type checking outputs based on changes I make to pyright. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mypy_primer -k trio --old 1.6.1
indicates that most of the diff is changes introduced between 1.6.1 and mypy head. src/trio/_tests/test_exports.py:158: error: Unused "type: ignore" comment [unused-ignore]
is the only one that is due to an env difference.
It's good to add pyright for trio even if pyright doesn't currently run cleanly on trio
I unfortunately don't seem to be able to run mypy_primer w/ pyright locally so I can't check if that works. (Windows has a cryptic error and WSL says npm fails...) EDIT: fixed (I'll probably PR the fix soon enough) and:
... Hopefully that's fine; I assume pyright would be complaining about our |
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Thanks again! |
Trio's an alternative async library that I help maintain!
Here's a couple reasons why this might help mypy primer output:
Never
inferred in complex situation with variadic callable protocol python/mypy#16522