Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally run mypyc on projects #41

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

zsol
Copy link

@zsol zsol commented Jul 16, 2022

This PR

  • allows Projects to run a custom command to verify if mypyc breaks on the project.
  • turns this feature on for Black

Copy link
Owner

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Left two quick comments.

Do you have a sense of how long this takes? Might need to be able to flag this off to avoid slowing down typeshed CI (which won't benefit from this)

mypy_primer.py Outdated Show resolved Hide resolved
mypy_primer.py Outdated Show resolved Hide resolved
@zsol
Copy link
Author

zsol commented Jul 16, 2022

For Black this takes around 6 minutes on my laptop. Definitely worth gating off for typeshed. I can add a command line flag if that helps

@zsol zsol marked this pull request as ready for review July 16, 2022 16:02
@hauntsaninja
Copy link
Owner

A command line flag would be great!

@zsol
Copy link
Author

zsol commented Jul 16, 2022

I've addressed your comments in the new commit, going to add a command line flag now. Thanks for the blazing fast reviews :)

mypy_primer.py Outdated Show resolved Hide resolved
mypy_primer.py Outdated Show resolved Hide resolved
@mr-c
Copy link
Contributor

mr-c commented Nov 22, 2023

Ping; it would be great to have this for schema-salad and cwltool given the mypyc regressions we experienced in the last two releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants