-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally run mypyc on projects #41
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Left two quick comments.
Do you have a sense of how long this takes? Might need to be able to flag this off to avoid slowing down typeshed CI (which won't benefit from this)
For Black this takes around 6 minutes on my laptop. Definitely worth gating off for typeshed. I can add a command line flag if that helps |
A command line flag would be great! |
I've addressed your comments in the new commit, going to add a command line flag now. Thanks for the blazing fast reviews :) |
Ping; it would be great to have this for schema-salad and cwltool given the mypyc regressions we experienced in the last two releases |
This PR
mypyc
breaks on the project.