Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Craftitems #2472

Closed
Closed

Conversation

coolcoolcoolabed
Copy link
Contributor

It seemed to me that there wasn't enough craftable items so I made some more craftable items
I made some weapons crafted with bones and some random silly weapons along with some other things.

@niamu
Copy link
Member

niamu commented Jun 19, 2015

This is a lot to digest in a single pull request. 50 files, 791 lines added and several new items/weapons. I'd suggest breaking this up into standalone components so it is easier to test and digest.

@coolcoolcoolabed
Copy link
Contributor Author

will do

@coolcoolcoolabed
Copy link
Contributor Author

how would i do that?

@niamu
Copy link
Member

niamu commented Jun 20, 2015

@coolcoolcoolabed Decide what commits stand on their own as complete features. Possibly even amending those commits into several smaller commits. Then separate them into new branches locally and open new pull requests explaining what you changed and why you changed it.

@8bitgentleman
Copy link
Contributor

This is a lot to add to the game at once. Before we start just adding items , even though some of there are pretty cool, we need to discuss how they fit into the game as a whole.

@didory123
Copy link
Member

Wow, this is actually pretty cool. I really like the sprite for the magic wand. If we could do some sort of level expansion along with the new items, I would be fine with this pull.

@8bitgentleman
Copy link
Contributor

I was just thinking that it would be cool to have enchanted versions of some of the weapons that are already in game. Maybe the player encounters a wizard in gay island who will enchant a weapon that you give him for a price.

@didory123
Copy link
Member

@8bitgentleman That would be pretty cool. I'm open to any suggestions about improving our weapon variety.

@niamu niamu force-pushed the master branch 2 times, most recently from de2bca9 to 20307b1 Compare September 25, 2015 21:55
@edisonout edisonout mentioned this pull request Oct 22, 2015
@edisonout
Copy link
Member

Some cool ideas but needs some work/discussion on how we incorporate them into the game, otherwise the player is just going to be overrun with choice. I've linked to this post in our ideas thread so none of your hard work will get lost/forgotten.

@edisonout edisonout closed this Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants