Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(maitake): implement JoinHandles #261

Merged
merged 23 commits into from
Jul 26, 2022
Merged

feat(maitake): implement JoinHandles #261

merged 23 commits into from
Jul 26, 2022

Conversation

hawkw
Copy link
Owner

@hawkw hawkw commented Jul 23, 2022

This mostly works now, it probably needs more tests

@hawkw hawkw requested a review from jamesmunns July 23, 2022 19:58
@hawkw hawkw force-pushed the eliza/joinwaker branch from 51f1308 to 31b3228 Compare July 25, 2022 16:21
hawkw added 20 commits July 25, 2022 19:07
@hawkw
wip joinhandle
f6eabe0 
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw
wip
edb1151
@hawkw
add joinhandle tests
06290c5
@hawkw
fix tracing log support being enabled somehow
9259075
@hawkw
add tracing for state transitions
5f85ea5 
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw
wip bad fix for scheduler dropping joinhandles
6a80afa
@hawkw
add test for joinhandle drops
a35a275 
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
@hawkw
probably excessive debug logging
1fc319a
@hawkw
no longer need to leak stub joinhandle
de5afac
@hawkw
clear join interest when joinhandle polls ready
2fa7a0a
@hawkw
only joinhandle clears join handle bit
edc360e
@hawkw
document possible optimization
c927fc1
@hawkw
fix loom test
0a57c4a
@hawkw
add quick loom leak check test
f419617
@hawkw
add some quick loom tests
192bba6
@hawkw
demote some verbose statecell logs to trace
b6665e3
@hawkw
fix wrong waitcell error handling
5974753
@hawkw
slight improvement to joinhandle drop logs
9ae7573
@hawkw
only add source locs to test_dbg!
47e5548
@hawkw
fix deadlock on joinwaker wait cell
7ed8367
@hawkw hawkw force-pushed the eliza/joinwaker branch from a35527f to 7ed8367 Compare July 26, 2022 02:08
@hawkw hawkw marked this pull request as ready for review July 26, 2022 02:09
@hawkw
Copy link
Owner Author

hawkw commented Jul 26, 2022

I think we can move forward with this. There's lots of room for improvement, but it works, and it has some tests...

jamesmunns
jamesmunns approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits, but looks super good! Looking forward to using this :D

maitake/src/task.rs Outdated Show resolved Hide resolved
maitake/src/task.rs Show resolved Hide resolved
@hawkw hawkw enabled auto-merge (squash) July 26, 2022 16:52
@hawkw hawkw merged commit f744e6b into main Jul 26, 2022
@hawkw hawkw deleted the eliza/joinwaker branch July 26, 2022 16:52
This was referenced Jul 26, 2022
Closed
Open
Open
hawkw added a commit that referenced this pull request Jul 27, 2022
@hawkw
docs(maitake): additional task and JoinHandle docs
8444f52 
These were supposed to be added in #261 but I must have forgot to
commit them.
@hawkw hawkw mentioned this pull request Jul 27, 2022
Merged
hawkw added a commit that referenced this pull request Jul 27, 2022
@hawkw
docs(maitake): additional task and JoinHandle docs (#268)
29cb03b 
These were supposed to be added in #261 but I must have forgot to
commit them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmunns jamesmunns jamesmunns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawkw @jamesmunns