Jolokia 2.1

[grgrzybek]

No description provided.

[hawtio-ci]

Test results

Run attempt: 2322
Detailed summary

NAME	TESTS	PASSED ✅	SKIPPED 💤	FAILED ❌	ERRORS 🚫	TIME 🕖
test-results-quarkus-node(18)-java(17)-firefox	67	64	3	0	0	327.344
test-results-quarkus-node(18)-java(21)-firefox	67	64	3	0	0	320.404
test-results-quarkus-node(20)-java(17)-firefox	67	64	3	0	0	328.854
test-results-quarkus-node(20)-java(21)-firefox	67	64	3	0	0	320.582
test-results-springboot-node(18)-java(17)-firefox	67	63	4	0	0	321.172
test-results-springboot-node(18)-java(21)-firefox	67	63	4	0	0	319.459
test-results-springboot-node(20)-java(17)-firefox	67	63	4	0	0	319.097
test-results-springboot-node(20)-java(21)-firefox	67	63	4	0	0	328.536

[github-actions]

Test Results

  8 files  ±0    8 suites  ±0   43m 5s ⏱️ + 1m 6s
 66 tests ±0   64 ✅ ±0   2 💤 ±0  0 ❌ ±0 
536 runs  ±0  508 ✅ ±0  28 💤 ±0  0 ❌ ±0 

Results for commit dab6b29. ± Comparison against base commit c6fe03c.

♻️ This comment has been updated with latest results.

[grgrzybek]

@mmuzikar may I ask for help? Is there a known problem in hawtio e2e tests, or did I break something by removing jquery?

[mmuzikar]

@grgrzybek
I will take a look at it, from the reports there's a ton of the same error: JavaScript error: http://localhost:3000/hawtio/static/js/vendors-node_modules_module-federation_utilities_dist_index_cjs_js-node_modules_patternfly_re-2ef800.chunk.js line 16585 > eval, line 26: TypeError: Jolokia is undefined

[grgrzybek]

@mmuzikar I only saw that after trying to run yarn start. Thanks for your time, but it's definitely my fault with this line: https://github.com/jolokia/jolokia/blob/bf354b1c80fa5decb8c46c78117243273725a144/client/javascript-esm/packages/jolokia-simple/package.json#L23 which I changed from:

"default": "./src/jolokia-simple.ts"

to:

"default": "./dist/jolokia-simple.js"

[grgrzybek]

darn... ES modules vs. node require() again...

[tadayosi]

@grgrzybek Btw, can you please follow the commit message convention? Otherwise, the commit-and-tag-version cannot pick up the changes correctly for automated releases.

[grgrzybek]

Btw, can you please follow the commit message convention

ah, sorry - old habits...

[tadayosi]

LGTM.

Just curious about what was the culprit of the last e2e issue?

[tadayosi]

Great job!

[grgrzybek]

LGTM.

Just curious about what was the culprit of the last e2e issue?

it was silly mistake related to switch from $.ajax to fetch() in Jolokia.

We had this:

hawtio-next/packages/hawtio/src/plugins/shared/jolokia-service.ts

Line 268 in c6fe03c

$.ajaxSetup({ beforeSend })

and I simply removed it. The fix was simply to actually set up the credentials to be passed directly to Jolokia constructor:

hawtio-next/packages/hawtio/src/plugins/shared/jolokia-service.ts

Line 322 in dab6b29

private async configureAuthorization(options: RequestOptions): Promise<undefined> {