Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jolokia 2.1 #1111

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Jolokia 2.1 #1111

merged 1 commit into from
Sep 12, 2024

Conversation

grgrzybek
Copy link
Contributor

No description provided.

@hawtio-ci
Copy link

hawtio-ci bot commented Sep 10, 2024

Test results

Run attempt: 2322
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
test-results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 327.344
test-results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 320.404
test-results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 328.854
test-results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 320.582
test-results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 321.172
test-results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 319.459
test-results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 319.097
test-results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 328.536

Copy link

github-actions bot commented Sep 10, 2024

Test Results

  8 files  ±0    8 suites  ±0   43m 5s ⏱️ + 1m 6s
 66 tests ±0   64 ✅ ±0   2 💤 ±0  0 ❌ ±0 
536 runs  ±0  508 ✅ ±0  28 💤 ±0  0 ❌ ±0 

Results for commit dab6b29. ± Comparison against base commit c6fe03c.

♻️ This comment has been updated with latest results.

@grgrzybek
Copy link
Contributor Author

@mmuzikar may I ask for help? Is there a known problem in hawtio e2e tests, or did I break something by removing jquery?

@mmuzikar
Copy link
Contributor

@grgrzybek
I will take a look at it, from the reports there's a ton of the same error: JavaScript error: http://localhost:3000/hawtio/static/js/vendors-node_modules_module-federation_utilities_dist_index_cjs_js-node_modules_patternfly_re-2ef800.chunk.js line 16585 > eval, line 26: TypeError: Jolokia is undefined

@grgrzybek
Copy link
Contributor Author

@mmuzikar I only saw that after trying to run yarn start. Thanks for your time, but it's definitely my fault with this line: https://github.com/jolokia/jolokia/blob/bf354b1c80fa5decb8c46c78117243273725a144/client/javascript-esm/packages/jolokia-simple/package.json#L23 which I changed from:

"default": "./src/jolokia-simple.ts"

to:

"default": "./dist/jolokia-simple.js"

@grgrzybek
Copy link
Contributor Author

darn... ES modules vs. node require() again...

@tadayosi
Copy link
Member

@grgrzybek Btw, can you please follow the commit message convention? Otherwise, the commit-and-tag-version cannot pick up the changes correctly for automated releases.

@grgrzybek
Copy link
Contributor Author

Btw, can you please follow the commit message convention

ah, sorry - old habits...

@grgrzybek grgrzybek force-pushed the jolokia-2.1 branch 4 times, most recently from 850b3ac to ef09ff9 Compare September 11, 2024 10:19
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just curious about what was the culprit of the last e2e issue?

@tadayosi
Copy link
Member

Great job!

@grgrzybek
Copy link
Contributor Author

LGTM.

Just curious about what was the culprit of the last e2e issue?

it was silly mistake related to switch from $.ajax to fetch() in Jolokia.

We had this:

and I simply removed it. The fix was simply to actually set up the credentials to be passed directly to Jolokia constructor:

private async configureAuthorization(options: RequestOptions): Promise<undefined> {

@grgrzybek grgrzybek merged commit 1658a7b into main Sep 12, 2024
13 checks passed
@grgrzybek grgrzybek deleted the jolokia-2.1 branch September 12, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants