Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMX - Copy actions on an operation don't work if Hawtio is accessed at a host other than localhost #628

Closed
tadayosi opened this issue Oct 23, 2023 · 3 comments · Fixed by #1086
Assignees
Labels
area/jmx good first issue Good for newcomers help wanted Extra attention is needed kind/ux Issues relating to user experience
Milestone

Comments

@tadayosi
Copy link
Member

If Hawtio is accessed at 0.0.0.0:8080 for instance instead of localhost:8080, Copy method name and Copy Jolokia URL actions provided by the Operations tab don't work as follows:

image

It is because navigator.clipboard.writeText works only under https unless it's localhost.
https://developer.mozilla.org/en-US/docs/Web/API/Clipboard

@tadayosi tadayosi added kind/bug Something isn't working area/jmx help wanted Extra attention is needed labels Oct 23, 2023
@tadayosi
Copy link
Member Author

Should we find some way to get around with the limitation or keep it as is honouring the security consideration done at navigator.clipboard.writeText? If we keep it as is, we can disable the menus when the console is on http and not localhost.

@phantomjinx
Copy link
Member

My preference would be to disable the menus and maybe put up a toast that notifies the user that the connection is not secure.

@tadayosi
Copy link
Member Author

Showing a warning notification with instruction on why it didn't work sounds like a good solution.

@tadayosi tadayosi added the good first issue Good for newcomers label Nov 14, 2023
@tadayosi tadayosi added this to the 2024Q2 milestone Feb 5, 2024
@tadayosi tadayosi added kind/ux Issues relating to user experience and removed kind/bug Something isn't working labels Feb 5, 2024
@tadayosi tadayosi modified the milestones: 2024Q2, 2024Q3 Jul 17, 2024
@mmuzikar mmuzikar self-assigned this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jmx good first issue Good for newcomers help wanted Extra attention is needed kind/ux Issues relating to user experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants