Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add warning for copying not working in insecure contexts #1086

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

mmuzikar
Copy link
Contributor

@mmuzikar mmuzikar commented Aug 29, 2024

Warning is displayed both in the dropdown and an alert gets displayed for the user to copy the text manually.
Peek 2024-08-29 10-16.webm

Also, I tweaked the event service to be able to render any ReactNode, not just strings, but as string is also a ReactNode it just extended the uses.

Closes #628

Copy link

github-actions bot commented Aug 29, 2024

Test Results

  8 files  ± 0    8 suites  ±0   42m 7s ⏱️ + 5m 25s
 66 tests ± 0   64 ✅ ± 0   2 💤 ±0  0 ❌ ±0 
536 runs  +66  508 ✅ +63  28 💤 +3  0 ❌ ±0 

Results for commit 88a0e57. ± Comparison against base commit 4368104.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Aug 29, 2024

Test results

Run attempt: 2213
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 316.93
results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 321.719
results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 313.736
results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 317.402
results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 312.884
results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 315.995
results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 312.188
results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 316.765

@tadayosi tadayosi merged commit bdc7f40 into hawtio:main Aug 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JMX - Copy actions on an operation don't work if Hawtio is accessed at a host other than localhost
2 participants