Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using jolokia.js and create a homebrew minimal Jolokia library #8

Closed
tadayosi opened this issue Oct 7, 2022 · 6 comments
Closed
Labels
kind/enhancement Enhancements that don't necessarily result in a new feature kind/refactoring Code improvements that don't add or change features

Comments

@tadayosi
Copy link
Member

tadayosi commented Oct 7, 2022

jolokia.js depends on jQuery only for ajax communications, which is not preferrable as it will solicit a ton of vulnerabilities on jQuery to the project. We can rewrite only a subset of Jolokia functionalities that Hawtio really relies on with a lighter HTTP client library such as axios and switch to it.

@tadayosi tadayosi added the kind/enhancement Enhancements that don't necessarily result in a new feature label Dec 22, 2022
@tadayosi tadayosi added this to the Future milestone Jan 10, 2023
@tadayosi tadayosi added the kind/refactoring Code improvements that don't add or change features label Feb 3, 2023
@tadayosi
Copy link
Member Author

tadayosi commented Feb 8, 2023

Or maybe better to just use the built-in fetch API.

@joshiraez
Copy link
Contributor

Can I assign myself to this? I might be able to tackle it after finishikg the JMX Chart feature

@joshiraez joshiraez self-assigned this Apr 8, 2023
@tadayosi
Copy link
Member Author

@joshiraez Don't do this now. It's a future task, the lowest priority. There are higher ones within 0.3 or 0.x milestones.

@joshiraez
Copy link
Contributor

joshiraez commented Apr 11, 2023 via email

@tadayosi
Copy link
Member Author

tadayosi commented Jun 7, 2023

Let me just clear assignment to this issue for now, as we won't work on it soon.

@tadayosi
Copy link
Member Author

tadayosi commented Feb 5, 2024

Once the jolokia project implements this jolokia/jolokia#580 we can use it. Let's close this in favour of the Jolokia issue.

@tadayosi tadayosi closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
@lhein lhein removed this from the Future milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancements that don't necessarily result in a new feature kind/refactoring Code improvements that don't add or change features
Projects
Archived in project
Development

No branches or pull requests

3 participants