Refactor paginated and filetered tables into one component #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test resultsRun attempt: 2218
|
mmuzikar
changed the title
|
@mmelko Could you review this as well, as this touches the parts you developed? |
|
@mmuzikar I noticed that the Logs table is quite changed from the previous. There is a one small issue, when you click on the Clear All Filters there .. the Log level isn't cleared. |
mmuzikar
force-pushed
the
gh-1004-1005
branch
from
8c80f34
to
962e04b
Compare
|
@mmelko fixed |
mmelko
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a FilteredTable component that can be used for generic rendering of tables with filters, sorting and search. Fixes the pagination issues where the page would always reset and is keeping the same features so far
Fixes #1004
Fixes #1005