Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared): Stop using jquery (for ajax and selection) (closes #76) #1114

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

grgrzybek
Copy link
Contributor

No description provided.

@grgrzybek
Copy link
Contributor Author

This one is easier than Jolokia 2.1.x migration.

Copy link

Test Results

  8 files  ±0    8 suites  ±0   42m 51s ⏱️ +5s
 66 tests ±0   64 ✅ ±0   2 💤 ±0  0 ❌ ±0 
536 runs  ±0  508 ✅ ±0  28 💤 ±0  0 ❌ ±0 

Results for commit 69d09cc. ± Comparison against base commit 1658a7b.

@hawtio-ci
Copy link

hawtio-ci bot commented Sep 12, 2024

Test results

Run attempt: 2324
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
test-results-quarkus-node(18)-java(17)-firefox 67 64 3 0 0 322.19
test-results-quarkus-node(18)-java(21)-firefox 67 64 3 0 0 318.911
test-results-quarkus-node(20)-java(17)-firefox 67 64 3 0 0 321.519
test-results-quarkus-node(20)-java(21)-firefox 67 64 3 0 0 320.614
test-results-springboot-node(18)-java(17)-firefox 67 63 4 0 0 326.14
test-results-springboot-node(18)-java(21)-firefox 67 63 4 0 0 318.84
test-results-springboot-node(20)-java(17)-firefox 67 63 4 0 0 324.067
test-results-springboot-node(20)-java(21)-firefox 67 63 4 0 0 318.821

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe we should then check whether the changes don't break integration with Keycloak and OIDC.

@grgrzybek
Copy link
Contributor Author

Maybe we should then check whether the changes don't break integration with Keycloak and OIDC.
I have hawtio/hawtio#3404 for that.

Actually one of the big arguments to move to fetch() API (and expose headers configuration for Jolokia) was to handle XSRF tokens - we didn't have this before. And this caused problems with Spring Security + OIDC.

I'll merge first this one and then continue the work.

@grgrzybek grgrzybek merged commit f1809c5 into main Sep 12, 2024
13 checks passed
@grgrzybek grgrzybek deleted the no-jquery branch September 12, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants