Create centralised backport workflow
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldziedziul
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Tested via dummy PR in test repo that backported successfully (via JackPGreen2/hz-docs#26).
From what I see in https://github.com/JackPGreen2/hz-docs/actions/runs/12029776846/job/33535776479 the action was skipped in all cases.
Fixed link. |
nishaatr
requested changes
Nov 26, 2024
JackPGreen
force-pushed
the
centralise-to-workflow
branch
from
bada218 to
7755724
Compare
JackPGreen
force-pushed
the
centralise-to-workflow
branch
from
70180ae to
c92f1af
Compare
JackPGreen
force-pushed
the
centralise-to-workflow
branch
from
3987032 to
23f82cb
Compare
nishaatr
approved these changes
Nov 27, 2024
ldziedziul
approved these changes
Nov 27, 2024
JackPGreen
added a commit
to hazelcast/hz-docs
that referenced
this pull request
Dec 2, 2024
…8] (#1396) In [DOC-255](https://hazelcast.atlassian.net/browse/DOC-255), branch protection was added - preventing direct `push`es. Instead, the backport workflow should create PRs to backport the changes. This gives the _possibility_ for pre-merge checks to be run (i.e. preventing introducing dead links etc). Leverages [_existing_ `backport` tool](https://github.com/hazelcast/backport), but exposed some issues which need to be addressed **before this can be merged**: - hazelcast/backport#14 - hazelcast/backport#15 - hazelcast/backport#16 - hazelcast/backport#17 Tested in a [test repo](https://github.com/JackPGreen2/hz-docs), where a [dummy PR](JackPGreen2#5) was [successfully backported](JackPGreen2#16). However, due to the complexity of fork-triggering, it wil need to be re-tested once merged. Fixes: [DOC-268](https://hazelcast.atlassian.net/browse/DOC-268) [DOC-255]: https://hazelcast.atlassian.net/browse/DOC-255?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [DOC-268]: https://hazelcast.atlassian.net/browse/DOC-268?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
JackPGreen
added a commit
to JackPGreen/backport
that referenced
this pull request
Dec 3, 2024
Following hazelcast#17, [backport PRs are being raised by `github-actions`](hazelcast/hazelcast-mono#3669), rather than using the specified `GH_TOKEN`
JackPGreen
added a commit
that referenced
this pull request
Dec 3, 2024
Following #17, [backport PRs are being raised by `github-actions`](hazelcast/hazelcast-mono#3669), rather than using the specified `GH_TOKEN`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support
backportbeing used in multiple GitHub Actions:A composite GitHub Action has been created to centralise it's usage, to make callers simpler.
Implementation is a sliced from
hazelcast-mono, with some parameters now explicit inputs.Tested via dummy PR in test repo that backported successfully (via JackPGreen2/hz-docs#26).