Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all DEVEL refs [DI-241] #38

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Remove all DEVEL refs [DI-241] #38

merged 3 commits into from
Aug 16, 2024

Conversation

nishaatr
Copy link
Contributor

@nishaatr nishaatr commented Aug 15, 2024

Remove all DEVEL refs as we don't package DEVEL - only produce Docker image
See JIRA for more details

Not sure about the below as url is pointing to JFrog devel repo. I think we can delete but do confirm?

https://github.com/hazelcast/homebrew-hz/blob/master/hazelcast-enterprise%405.1.dr6.rb
https://github.com/hazelcast/homebrew-hz/blob/master/hazelcast-enterprise%405.1.dr8.rb

image

Accompanied by hazelcast/hazelcast-packaging#224

Fixes DI-241

@nishaatr nishaatr changed the title Remove all DEVEL refs Remove all DEVEL refs [DI-241] Aug 15, 2024
Copy link
Contributor

@JackPGreen JackPGreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because these files are dynamically generated, I think any modification should wait until the generator (i.e. hazelcast/hazelcast-packaging#224) is updated.
Otherwise an intermediate build will cause conflicts.

@nishaatr
Copy link
Contributor Author

Because these files are dynamically generated, I think any modification should wait until the generator (i.e. hazelcast/hazelcast-packaging#224) is updated. Otherwise an intermediate build will cause conflicts.

Makes sense. thanks

Copy link
Contributor

@ldziedziul ldziedziul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all DEVEL refs as we don't package DEVEL - only produce Docker image See JIRA for more details

Not sure about the below as url is pointing to JFrog devel repo. I think we can delete but do confirm?

DR means devel release, it was a previous name, we can delete them as well

@nishaatr
Copy link
Contributor Author

nishaatr commented Aug 16, 2024

Remove all DEVEL refs as we don't package DEVEL - only produce Docker image See JIRA for more details
Not sure about the below as url is pointing to JFrog devel repo. I think we can delete but do confirm?

DR means devel release, it was a previous name, we can delete them as well

Ah. should have been obvious. Normally DR means disaster recovery!
I will remove them soon. thanks

REMOVED: 2cdc9e7f4

@ldziedziul
Copy link
Contributor

It's good that you haven't removed anything you wasn't sure 💪

@nishaatr
Copy link
Contributor Author

It's good that you haven't removed anything you wasn't sure 💪

thanks. What can I say, I am risk averse. In my nature + I think I have learnt the hard way 🙂

nishaatr added a commit to hazelcast/hazelcast-packaging that referenced this pull request Aug 16, 2024
Remove all DEVEL refs as we don't package DEVEL - only produce Docker
image. See JIRA for more details

Accompanied by hazelcast/homebrew-hz#38

Fixes [DI-241](https://hazelcast.atlassian.net/browse/DI-241)

---------

Co-authored-by: Jack Green <jack.green@hazelcast.com>
@nishaatr nishaatr merged commit e69061e into master Aug 16, 2024
1 check passed
@nishaatr nishaatr deleted the DI-241-cleanup-devel branch August 16, 2024 10:56
nishaatr added a commit to hazelcast/hazelcast-packaging that referenced this pull request Aug 16, 2024
Remove all DEVEL refs as we don't package DEVEL - only produce Docker
image. See JIRA for more details

Accompanied by hazelcast/homebrew-hz#38

Fixes [DI-241](https://hazelcast.atlassian.net/browse/DI-241)

---------

Co-authored-by: Jack Green <jack.green@hazelcast.com>
nishaatr added a commit to hazelcast/hazelcast-packaging that referenced this pull request Aug 16, 2024
Remove all DEVEL refs as we don't package DEVEL - only produce Docker
image. See JIRA for more details

Accompanied by hazelcast/homebrew-hz#38

Fixes [DI-241](https://hazelcast.atlassian.net/browse/DI-241)

---------

Co-authored-by: Jack Green <jack.green@hazelcast.com>
nishaatr added a commit to hazelcast/hazelcast-packaging that referenced this pull request Aug 16, 2024
Remove all DEVEL refs as we don't package DEVEL - only produce Docker
image. See JIRA for more details

Accompanied by hazelcast/homebrew-hz#38

Fixes [DI-241](https://hazelcast.atlassian.net/browse/DI-241)

---------

Co-authored-by: Jack Green <jack.green@hazelcast.com>
nishaatr added a commit to hazelcast/hazelcast-packaging that referenced this pull request Aug 16, 2024
Remove all DEVEL refs as we don't package DEVEL - only produce Docker
image. See JIRA for more details

Accompanied by hazelcast/homebrew-hz#38

Fixes [DI-241](https://hazelcast.atlassian.net/browse/DI-241)

---------

Co-authored-by: Jack Green <jack.green@hazelcast.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants