fix: incorrect mypy diagnosis of Unpack[ExtraArgs].

hbldh · Dec 30, 2023 · 2d1ddf5 · 2d1ddf5
1 parent 13c0e0c
commit 2d1ddf5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/AUTHORS.rst b/AUTHORS.rst
@@ -22,6 +22,7 @@ Contributors
 * Edward Betts <edward@4angle.com>
 * Robbe Gaeremynck <robbe.gaeremynck@outlook.com>
 * David Johansen <davejohansen@gmail.com>
+* JP Hutchins <jphutchins@gmail.com>
 
 Sponsors
 --------

diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -22,6 +22,7 @@ Changed
 Fixed
 -----
 * Fixed BlueZ version in passive scanning error message. Fixes #1433.
+* Fixed mypy requiring ``Unpack[ExtraArgs]`` that were intended to be optional.  Fixes #1487.
 
 `0.21.1`_ (2023-09-08)
 ======================

diff --git a/bleak/__init__.py b/bleak/__init__.py
@@ -245,7 +245,7 @@ async def advertisement_data(
         finally:
             unregister_callback()
 
-    class ExtraArgs(TypedDict):
+    class ExtraArgs(TypedDict, total=False):
         """
         Keyword args from :class:`~bleak.BleakScanner` that can be passed to
         other convenience methods.