Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore None type device address when using bdaddr #1524

Closed
wants to merge 2 commits into from
Closed

Ignore None type device address when using bdaddr #1524

wants to merge 2 commits into from

Conversation

rrooggiieerr
Copy link
Contributor

Pull Request Guidelines for Bleak

Before you submit a pull request, check that it meets these guidelines:

  1. If the pull request adds functionality, the docs should be updated.
  2. Modify the CHANGELOG.rst, describing your changes as is specified by the
    guidelines in that document.
  3. The pull request should work for Python 3.8+ on the following platforms:
    • Windows 10, version 16299 (Fall Creators Update) and greater
    • Linux distributions with BlueZ >= 5.43
    • OS X / macOS >= 10.11
  4. Squash all your commits on your PR branch, if the commits are not solving
    different problems and you are committing them in the same PR. In that case,
    consider making several PRs instead.
  5. Feel free to add your name as a contributor to the AUTHORS.rst file!

@rrooggiieerr
Copy link
Contributor Author

Solves #1523

@dlech dlech linked an issue Mar 15, 2024 that may be closed by this pull request
@rrooggiieerr rrooggiieerr closed this by deleting the head repository Apr 17, 2024
@dlech
Copy link
Collaborator

dlech commented Apr 17, 2024

Did you decide this isn't needed after all or did you just get tired of waiting?

@rrooggiieerr
Copy link
Contributor Author

I only get the 'NoneType' exception on my development MacBook and am currently not working on Bluetooth based integrations. My live system works on HAOS and thus doesn't have the problem.

So urgency isn't high for me, but it does solve a problem

@rrooggiieerr
Copy link
Contributor Author

Ah, now I understand why you were asking. I removed a bunch of forked repositories including the bleak one which automatically closed this issue.

@dlech
Copy link
Collaborator

dlech commented Apr 18, 2024

FYI, I can't merge or re-open the PR with the branch gone.

@rrooggiieerr
Copy link
Contributor Author

OK, see #1539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

corebluetooth scanner does not check on None vallue address
2 participants