Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During init() support raising a "BLE is unsupported" #533

Merged
merged 2 commits into from
May 11, 2021
Merged

During init() support raising a "BLE is unsupported" #533

merged 2 commits into from
May 11, 2021

Conversation

epoz
Copy link
Contributor

@epoz epoz commented May 5, 2021

For some older devices the bluetooth stack does not support BLE.

The error message "Bluetooth device is turned off" can then be confusing, if on that device bluetooth is actually switched on (and working) but the actual problem is that BLE is not supported.

For some older devices the bluetooth stack does not support BLE.

The error message "Bluetooth device is turned off" can then be confusing, if on that device bluetooth is actually switched on (and working) but the actual problem is that BLE is not supported.
Copy link
Collaborator

@dlech dlech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@dlech
Copy link
Collaborator

dlech commented May 11, 2021

Could you run black on the code or manually delete the trailing white space on the blank lines?

@epoz
Copy link
Contributor Author

epoz commented May 11, 2021

Could you run black on the code or manually delete the trailing white space on the blank lines?

The patch was submitted using the web-editor of Github directly, I never did a local checkout. Lemme see if I can do a manual edit...

@dlech dlech merged commit 0f74fc0 into hbldh:develop May 11, 2021
@dlech
Copy link
Collaborator

dlech commented May 11, 2021

Thanks!

@epoz epoz deleted the patch-1 branch May 11, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants