Discovery filter #565
Merged
Discovery filter #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on. Added example that uses this functionality to find devices by name.
dlech
reviewed
Jun 5, 2021
|
And please add a changelog entry as well. |
…ameters on the command line
|
Except for the filter function signature I think it's all there now. I did accidentally mark the "args for examples" discussion as done and I can't see how to undo that. |
hbldh
approved these changes
Jun 7, 2021
dlech
reviewed
Jun 7, 2021
Since we can await the asyncio.Queue, we no longer need an asyncio.Event(). Also remove unused timeout kwarg while we are touching this code.
|
Merged, thanks! |
jeffsf
added a commit
to jeffsf/pyDE1
that referenced
this pull request
Jun 12, 2021
An outbound API (notifications) is provided in a separate process.
The present implementation uses MQTT and provides timestamped,
source-identified, semantically versioned JSON payloads for:
* DE1
* Connectivity
* State updates
* Shot samples with accumulated volume
* Water levels
* Scale
* Connectivity
* Weight and flow updates
* Flow sequencer
* "Gate" clear and set
* Sequence start
* Flow begin
* Expect drops
* Exit preinfuse
* Flow end
* Flow-state exit
* Last drops
* Sequence complete
* Stop-at-time/volume/weight
* Enable, disable (with target)
* Trigger (with target and value at trigger)
An example subscriber is provided in `examples/monitor_delay.py`.
On a Raspberry Pi 3B, running Debian Buster and `mosquitto` 2.0
running on `::`, median delays are under 10 ms from the arrival_time
of the triggering event to delivery of the MQTT packet to the subscriber.
Packets are being sent with retain True, so that, for example, the
subscriber has the last-known DE1 state without having to wait for a
state change. Checking the payload's `arrival_time` is suggested to
determine if the data is fresh enough. The will feature of MQTT has
not yet been implemented.
One good thing about MQTT is that you can have as many subscribers as
you want without slowing down the controller. For example, you can
have a live view on your phone, live view on your desktop, log to file,
log to database, all at once.
Scan For And Use First DE1 And Skale Found
Though "WET" and needing to be "DRY", the first-found DE1 and Skale
will be used. The Scale class has already been designed to be able to
have each subclass indicate if it recognizes the advertisement. Once
DRY, the scanner should be able to return the proper scale from any of
the alternatives.
Refactoring of this is pending the formal release of
`BleakScanner.find_device_by_filter(filterfunc)` from
bleak PR #565 hbldh/bleak#565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new method
BleakScanner.find_device_by_filter(filterfunc)that finds the first device that matches the filter function.There's a new example
scanner_byname.pythat is similar toscanner.pybut you specify the name of the BLE device you are looking for in stead of the address.(I haven't merged the commits, in case you want to partially accept this).