CoreBluetooth scan start/stop improvements #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes use of ObjC-style key-value observer to monitor the isScanning property on CBCentralManager. This allows us to avoid the polling wait. Previously, the wait was only implemented when stopping scanning, so it is added to the start as well. Also, the higher-level function is fixed to allow calling stop() multiple times without raising an error. This is needed since the stop() method can be called by __aexit__() even if the scanner is already stopped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of ObjC-style key-value observer to monitor the
isScanningproperty onCBCentralManager. This allows us to avoid the polling wait.Previously, the wait was only implemented when stopping scanning, so it is added to the start as well.
Also, the higher-level function is fixed to allow calling
stop()multiple times without raising an error. This is needed since thestop()method can be called by__aexit__()even if the scanner is already stopped.