fix: unexpected undefined size of icon #4977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduard Aksamitov <e@euaaaio.ru>
aonnikov
reviewed
Mar 15, 2024
| @@ -34,12 +34,15 @@ | |||
| $: url = isAsset(icon) ? getMetadata(toAsset(icon)) ?? 'https://anticrm.org/logo.svg' : '' | |||
|
|
|||
| $: _fill = iconProps?.fill ?? fill | |||
|
|
|||
| // workaround to prevent sveltejs bug in `svelte:component`: https://github.com/sveltejs/svelte/issues/9177 | |||
There was a problem hiding this comment.
This seems to be quite a major bug that might affect not only icons but potentially all places where we use svelte:component. How we can ensure those are not affected?
There was a problem hiding this comment.
Yes, we need to check all places where use use svelte:component and address them until issue will be fixed.
There was a problem hiding this comment.
Does svelte:self or svelte:fragment also affected?
There was a problem hiding this comment.
I've just found sveltejs/svelte#10604, and we probable should update to
svelte@4.2.12 to address it instead.
There was a problem hiding this comment.
Yeah, let's update to 4.2.12 and check if the issue is fixed.
|
Update to svelte helped, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution checklist
Brief description
This bug is caused by a bug in sveltejs, but we have a workaround
Screencast
Screen.Recording.2024-03-14.at.23.29.46.mov
Checklist
Related issues
Resolves #4960
Contributor requirements
View in Huly UBERF-6023