Refactor bad smells:

- UnnecessaryToStringCall The toString() method is not needed in cases the underlying method handles the conversion. Also calling toString() on a String is redundant. Removing them simplifies the code.
hcoles · Jan 6, 2023 · 65c47eb · 65c47eb
1 parent cca2ef2
commit 65c47eb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pitest-entry/src/main/java/org/pitest/mutationtest/statistics/Score.java b/pitest-entry/src/main/java/org/pitest/mutationtest/statistics/Score.java
@@ -43,11 +43,11 @@ public void report(final PrintStream out) {
       sb.append(each + " ");
       i++;
       if ((i % 4) == 0) {
-        out.println("> " + sb.toString());
+        out.println("> " + sb );
         sb = new StringBuilder();
       }
     }
-    out.println("> " + sb.toString());
+    out.println("> " + sb );
   }
 
   public String getMutatorName() {

diff --git a/pitest/src/main/java/org/pitest/util/Log.java b/pitest/src/main/java/org/pitest/util/Log.java
@@ -79,7 +79,7 @@ public String format(final LogRecord record) {
       if (throwable != null) {
         final StringWriter sink = new StringWriter();
         throwable.printStackTrace(new PrintWriter(sink, true));
-        buf.append(sink.toString());
+        buf.append(sink);
       }
 
       return buf.toString();